Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Short Circuit API] Replace names in FortescueValue #2494

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

colinepiloquet
Copy link
Member

@colinepiloquet colinepiloquet commented Mar 9, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Replace names: phases are now A,B,C and homopolar are now positive, negative, zero.

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.6% 90.6% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit f067e75 into main Mar 10, 2023
@annetill annetill deleted the replace_names_fortescue_value branch March 10, 2023 13:51
anistouri pushed a commit that referenced this pull request Mar 13, 2023
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants